This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Revert "Stop using asar archives" #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 15, 2017 19:01
|
Not sure if this is related, but I ran into atom/atom#6604 when testing for #745.
|
|
I think the asar was added back in Atom 1.21 so if you are testing the master version of apm using Atom 1.20 you would run into problems. |
|
@Ben3eeE thanks for the insight. I was testing with Atom 1.20 |
virtuoushub
referenced
this pull request
in virtuoushub/apm
Oct 19, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #693, since we turned .asar archives back on as part of atom/atom#14682.
@nathansobo: I believe this will fix the
Could not determine Electron versionerror we were observing when runningapm install./cc: @iolsen